linux-kernel - Re: [PATCH] ata: ahci: power off unused ports

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <484438BF.7070303@garzik.org>
Date:	Mon, 02 Jun 2008 14:15:27 -0400
From:	Jeff Garzik <jeff@...zik.org>
To:	kristen.c.accardi@...el.com
CC:	Mark Lord <liml@....ca>, Alan Cox <alan@...rguk.ukuu.org.uk>,
	Pavel Machek <pavel@....cz>, Theodore Tso <tytso@....edu>,
	linux-ide@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ata: ahci: power off unused ports

Kristen Carlson Accardi wrote:
> Here you can see that it would be very easy for another driver
> to just add code to set the NO_HOTPLUG flag and then this code
> will work for them as well, since we power off the phy using
> DET which is specified by SATA.

> here's that code:

Agreed.  The main discussion in this sub-thread is more about user 
interface.  The user interface in this case, a module option, is 
specific to AHCI.

Surely you can see how it is a bit silly to force each driver writer to 
create the same user interface in each driver, to support a generic concept.

	Jeff


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/