linux-kernel - Re: [PATCH 1/3] introduce PF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20080603141416.43afaeba.akpm@linux-foundation.org>
Date:	Tue, 3 Jun 2008 14:14:16 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Oleg Nesterov <oleg@...sign.ru>
Cc:	ebiederm@...ssion.com, mingo@...e.hu,
	torvalds@...ux-foundation.org, roland@...hat.com,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/3] introduce PF_KTHREAD flag

On Sun, 1 Jun 2008 19:30:42 +0400
Oleg Nesterov <oleg@...sign.ru> wrote:

> Introduce the new PF_KTHREAD flag to mark the kernel threads. It is set by
> INIT_TASK() and copied to the forked childs (we could set it in kthreadd()
> along with PF_NOFREEZE instead).
> 
> daemonize() was changed as well. In that case testing of PF_KTHREAD is racy,
> but daemonize() is hopeless anyway.
> 
> This flag is cleared in do_execve(), before search_binary_handler(). Probably
> not the best place, we can do this in exec_mmap() or in start_thread(), or
> clear it along with PF_FORKNOEXEC. But I think this doesn't matter in practice,
> and if do_execve() fails kthread should die soon.

The changelog doesn't explain why this change is being made, and I
wasn't able to work that out.

Similarly, I can kinda see what benefit "[PATCH 2/3] kill
PF_BORROWED_MM in favour of PF_KTHREAD" is bringing us, but it would be
nice to see that spelled out please.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/