linux-kernel - Re: [PATCH 3/3] coredump: zap_threads() must skip kernel threads

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20080603141548.15d60a32.akpm@linux-foundation.org>
Date:	Tue, 3 Jun 2008 14:15:48 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Oleg Nesterov <oleg@...sign.ru>
Cc:	ebiederm@...ssion.com, mingo@...e.hu,
	torvalds@...ux-foundation.org, roland@...hat.com,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/3] coredump: zap_threads() must skip kernel threads

On Sun, 1 Jun 2008 19:30:45 +0400
Oleg Nesterov <oleg@...sign.ru> wrote:

> The main loop in zap_threads() must skip kthreads which may use the same mm.
> Otherwise we "kill" this thread erroneously (for example, it can not fork or
> exec after that), and the coredumping task stucks in the TASK_UNINTERRUPTIBLE
> state forever because of the wrong ->core_waiters count.
> 
> Signed-off-by: Oleg Nesterov <oleg@...sign.ru>
> 
> --- 26-rc2/fs/exec.c~3_CD_FIX_RACE_USE_MM	2008-05-31 20:05:21.000000000 +0400
> +++ 26-rc2/fs/exec.c	2008-06-01 19:04:39.000000000 +0400
> @@ -1568,11 +1568,13 @@ static inline int zap_threads(struct tas
>  	for_each_process(g) {
>  		if (g == tsk->group_leader)
>  			continue;
> +		if (g->flags & PF_KTHREAD)
> +			continue;
>  
>  		p = g;
>  		do {
>  			if (p->mm) {
> -				if (p->mm == mm) {
> +				if (unlikely(p->mm == mm)) {
>  					lock_task_sighand(p, &flags);
>  					zap_process(p);
>  					unlock_task_sighand(p, &flags);

This is a bugfix, yes?

How does it get triggered?

Do you think the bug is sufficiently serious to fix it in 2.6.26?  In
2.6.25.x?  If so, it would be better if this patch were not dependent
upon the preceding ones, which do not appear to be 2.6.26 or -stable
material.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/