linux-kernel - Re: [PATCH -mm] clean up duplicated alloc/free_thread

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <84144f020806022306h236a48cbv32b82cfa83fe4ee6@mail.gmail.com>
Date:	Tue, 3 Jun 2008 09:06:26 +0300
From:	"Pekka Enberg" <penberg@...helsinki.fi>
To:	"FUJITA Tomonori" <fujita.tomonori@....ntt.co.jp>
Cc:	linux-kernel@...r.kernel.org, linux-arch@...r.kernel.org,
	akpm@...ux-foundation.org
Subject: Re: [PATCH -mm] clean up duplicated alloc/free_thread_info

On Tue, Jun 3, 2008 at 8:02 AM, FUJITA Tomonori
<fujita.tomonori@....ntt.co.jp> wrote:
> Is there a reason we duplicate alloc/free_thread_info defines on many
> platforms?

No. The patch looks good.

On Tue, Jun 3, 2008 at 8:02 AM, FUJITA Tomonori
<fujita.tomonori@....ntt.co.jp> wrote:
> Note:
>
> - I don't like __HAVE_ARCH_THREAD_INFO_ALLOCATOR name much. I chose
> that name just because we define __HAVE_ARCH_TASK_STRUCT_ALLOCATOR in
> the same place.
>
> - frv, m32r, mips, mn10300, and sh uses kmalloc/kfree instead of
> __get_free_pages/free_pages. I let them alone but it could remove more
> code if __get_free_pages/free_pages works for them.

Yeah, I too have wondered why some architectures use kmalloc() whereas
others use the page allocator. Is THREAD_SIZE significantly smaller
than PAGE_SIZE for those?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/