linux-kernel - [PATCH] uio_pdrv: Unique IRQ Mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20080604060826.17162.46972.sendpatchset@rx1.opensource.se>
Date:	Wed, 04 Jun 2008 15:08:26 +0900
From:	Magnus Damm <magnus.damm@...il.com>
To:	linux-kernel@...r.kernel.org
Cc:	Uwe.Kleine-Koenig@...i.com, gregkh@...e.de,
	akpm@...ux-foundation.org, hjk@...utronix.de, lethal@...ux-sh.org,
	Magnus Damm <magnus.damm@...il.com>, tglx@...utronix.de
Subject: [PATCH] uio_pdrv: Unique IRQ Mode

From: Magnus Damm <damm@...l.co.jp>

This patch adds a "Unique IRQ Mode" to the uio_pdrv UIO platform driver.
In this mode the user space driver is responsible for acknowledging and
re-enabling the interrupt. Shared interrupts are not supported.

Signed-off-by: Magnus Damm <damm@...l.co.jp>
---

Think of this as V2 of "[PATCH 00/03][RFC] Reusable UIO Platform Driver".
Needs "[PATCH 0/1] UIO: Add a write() function to enable/disable interrupts"

 drivers/uio/uio_pdrv.c |   43 +++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 43 insertions(+)

--- 0006/drivers/uio/uio_pdrv.c
+++ work/drivers/uio/uio_pdrv.c	2008-06-04 14:51:56.000000000 +0900
@@ -16,8 +16,34 @@
 
 struct uio_platdata {
 	struct uio_info *uioinfo;
+	unsigned long irq_disabled;
 };
 
+static irqreturn_t uio_pdrv_unique_handler(int irq, struct uio_info *dev_info)
+{
+	struct uio_platdata *priv = dev_info->priv;
+
+	/* In "Unique IRQ Mode", just disable the interrupt and remember
+	 * the state so we can enable it later.
+	 */
+	disable_irq(irq);
+	set_bit(0, &priv->irq_disabled);
+	return IRQ_HANDLED;
+}
+
+static int uio_pdrv_unique_irqcontrol(struct uio_info *dev_info, s32 irq_on)
+{
+	struct uio_platdata *priv = dev_info->priv;
+
+	/* "Unique IRQ Mode" allows re-enabling of the interrupt */
+	if (irq_on && test_and_clear_bit(0, &priv->irq_disabled)) {
+		enable_irq(dev_info->irq);
+		return 0;
+	}
+
+	return -ENOSYS;
+}
+
 static int uio_pdrv_probe(struct platform_device *pdev)
 {
 	struct uio_info *uioinfo = pdev->dev.platform_data;
@@ -68,6 +94,23 @@ static int uio_pdrv_probe(struct platfor
 
 	pdata->uioinfo->priv = pdata;
 
+	/* This driver supports a special "Unique IRQ Mode".
+	 *
+	 * In this mode, no hardware specific kernel code is required to
+	 * acknowledge interrupts. Instead, the interrupt is disabled by
+	 * the interrupt handler. User space is responsible for performing
+	 * hardware specific acknowledge and enabling of interrupts.
+	 *
+	 * Interrupt sharing is _not_ supported by the "Unique IRQ Mode".
+	 *
+	 * Enable this mode by passing IRQ number but omitting irq callbacks.
+	 */
+	if (!uioinfo->handler && !uioinfo->irqcontrol && uioinfo->irq >= 0) {
+		uioinfo->irq_flags = IRQF_DISABLED;
+		uioinfo->handler = uio_pdrv_unique_handler;
+		uioinfo->irqcontrol = uio_pdrv_unique_irqcontrol;
+	}
+
 	ret = uio_register_device(&pdev->dev, pdata->uioinfo);
 
 	if (ret) {
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/