linux-kernel - Re: [PATCH] cifs endianness fixes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <524f69650806032314j17554909h1a0c0d8f0e9b7820@mail.gmail.com>
Date:	Wed, 4 Jun 2008 01:14:46 -0500
From:	"Steve French" <smfrench@...il.com>
To:	torvalds@...ux-foundation.org
Cc:	sfrench@...ba.org, linux-kernel@...r.kernel.org,
	"Al Viro" <viro@....linux.org.uk>
Subject: Re: [PATCH] cifs endianness fixes

ACK

Please merge

On Mon, Jun 2, 2008 at 4:59 AM, Al Viro <viro@....linux.org.uk> wrote:
>
> __le16 fields used as host-endian.
>
> Signed-off-by: Al Viro <viro@...iv.linux.org.uk>
> ---
> diff --git a/fs/cifs/cifssmb.c b/fs/cifs/cifssmb.c
> index 9b8b4cf..fb655b4 100644
> --- a/fs/cifs/cifssmb.c
> +++ b/fs/cifs/cifssmb.c
> @@ -3927,9 +3927,9 @@ parse_DFS_referrals(TRANSACTION2_GET_DFS_REFER_RSP *pSMBr,
>        }
>
>        ref = (struct dfs_referral_level_3 *) &(pSMBr->referrals);
> -       if (ref->VersionNumber != 3) {
> +       if (ref->VersionNumber != cpu_to_le16(3)) {
>                cERROR(1, ("Referrals of V%d version are not supported,"
> -                       "should be V3", ref->VersionNumber));
> +                       "should be V3", le16_to_cpu(ref->VersionNumber)));
>                rc = -EINVAL;
>                goto parse_DFS_referrals_exit;
>        }
> @@ -3977,7 +3977,7 @@ parse_DFS_referrals(TRANSACTION2_GET_DFS_REFER_RSP *pSMBr,
>                if (rc)
>                        goto parse_DFS_referrals_exit;
>
> -               ref += ref->Size;
> +               ref += le16_to_cpu(ref->Size);
>        }
>
>  parse_DFS_referrals_exit:
>



-- 
Thanks,

Steve
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/