linux-kernel - Re: [PATCH] watchdog: Strip stray space in log message

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <200806041642.15522.jdelvare@suse.de>
Date:	Wed, 4 Jun 2008 16:42:15 +0200
From:	Jean Delvare <jdelvare@...e.de>
To:	Alan Cox <alan@...rguk.ukuu.org.uk>
Cc:	Wim Van Sebroeck <wim@...ana.be>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] watchdog: Strip stray space in log message

Hi Alan,

Le mercredi 04 juin 2008, Alan Cox a écrit :
> On Wed, 4 Jun 2008 15:38:53 +0200
> Jean Delvare <jdelvare@...e.de> wrote:
> 
> > Strip a stray space in log messages of 3 watchdog drivers.
> > (And fold these long lines to make checkpatch.pl happy.)
> 
> Don't break up strings of quoted text - it makes grepping for them much
> harder.

As written above, checkpatch.pl told me to break them up.

CodingStyle says: "Long strings are as well broken into shorter
strings." And quite rightly so IMHO, if you have to rely on grepping
the whole kernel tree to find out where a log message comes from, it
means that this log message is bad and needs to be improved.

Thanks,
-- 
Jean Delvare
Suse L3
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/