linux-kernel - Re: [PATCH] spi: fix list scan success verification in PXA ssp driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <f17812d70806050154u90fe08cu5ac1e29dbb2ae4d4@mail.gmail.com>
Date:	Thu, 5 Jun 2008 16:54:44 +0800
From:	"eric miao" <eric.y.miao@...il.com>
To:	"Guennadi Liakhovetski" <g.liakhovetski@...gutronix.de>
Cc:	linux-kernel@...r.kernel.org, dbrownell@...rs.sourceforge.net,
	"eric miao" <eric.miao@...vell.com>,
	spi-devel-general@...ts.sourceforge.net,
	"ARM Linux" <linux-arm-kernel@...ts.arm.linux.org.uk>
Subject: Re: [PATCH] spi: fix list scan success verification in PXA ssp driver

Acked-by: Eric Miao <eric.miao@...vell.com>

And this should really go through the ARM tree, please submit the
patch to RMK's patch system. Thanks.

(I have to send this again through my gmail account, please ignore the
other copy if any,
sorry for this)

On Thu, Jun 5, 2008 at 4:37 PM, Guennadi Liakhovetski
<g.liakhovetski@...gutronix.de> wrote:
> The list search success check in arch/arm/mach-pxa/ssp.c is wrong: for
> example, it didn't recognise failure for me when I requested port 0.
>
> Signed-off-by: Guennadi Liakhovetski <g.liakhovetski@...gutronix.de>
>
> ---
>
>  arch/arm/mach-pxa/ssp.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> Index: linux-2.6/arch/arm/mach-pxa/ssp.c
> ===================================================================
> --- linux-2.6.orig/arch/arm/mach-pxa/ssp.c      2008-06-04 12:11:26.000000000 +0200
> +++ linux-2.6/arch/arm/mach-pxa/ssp.c   2008-06-04 12:11:50.000000000 +0200
> @@ -330,7 +330,7 @@
>
>        mutex_unlock(&ssp_lock);
>
> -       if (ssp->port_id != port)
> +       if (&ssp->node == &ssp_list)
>                return NULL;
>
>        return ssp;
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
>



-- 
Cheers
- eric
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/