linux-kernel - RE: [PATCH] spi: fix list scan success verification in PXA ssp driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <E913911567467945BBEB9277E27868B0D6A414@msiexch01.marvell.com>
Date:	Thu, 5 Jun 2008 01:45:47 -0700
From:	"Eric Miao" <ymiao3@...vell.com>
To:	"Guennadi Liakhovetski" <g.liakhovetski@...gutronix.de>,
	<linux-kernel@...r.kernel.org>
Cc:	<dbrownell@...rs.sourceforge.net>,
	<spi-devel-general@...ts.sourceforge.net>,
	"Russell King" <rmk@....linux.org.uk>,
	<linux-arm-kernel@...ts.arm.linux.org.uk>
Subject: RE: [PATCH] spi: fix list scan success verification in PXA ssp driver

Acked-by: Eric Miao <eric.miao@...vell.com>

And this should really go through the ARM tree, please submit the patch
to RMK's patch system. Thanks.

Cheers
- eric

> -----Original Message-----
> From: Guennadi Liakhovetski [mailto:g.liakhovetski@...gutronix.de]
> Sent: Thursday, June 05, 2008 4:37 PM
> To: linux-kernel@...r.kernel.org
> Cc: dbrownell@...rs.sourceforge.net; Eric Miao;
> spi-devel-general@...ts.sourceforge.net
> Subject: [PATCH] spi: fix list scan success verification in PXA ssp driver
> 
> The list search success check in arch/arm/mach-pxa/ssp.c is wrong: for
> example, it didn't recognise failure for me when I requested port 0.
> 
> Signed-off-by: Guennadi Liakhovetski <g.liakhovetski@...gutronix.de>
> 
> ---
> 
>  arch/arm/mach-pxa/ssp.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> Index: linux-2.6/arch/arm/mach-pxa/ssp.c
> ===================================================================
> --- linux-2.6.orig/arch/arm/mach-pxa/ssp.c	2008-06-04 12:11:26.000000000
> +0200
> +++ linux-2.6/arch/arm/mach-pxa/ssp.c	2008-06-04 12:11:50.000000000 +0200
> @@ -330,7 +330,7 @@
> 
>  	mutex_unlock(&ssp_lock);
> 
> -	if (ssp->port_id != port)
> +	if (&ssp->node == &ssp_list)
>  		return NULL;
> 
>  	return ssp;