linux-kernel - reserve_bootmem_generic in early_res_to

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 9 Jun 2008 13:07:52 -0700
From:	"Yinghai Lu" <yhlu.kernel@...il.com>
To:	"Ingo Molnar" <mingo@...e.hu>
Cc:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: reserve_bootmem_generic in early_res_to_bootmem

can you make the 64 bit still use reserve_bootmem_generic in
early_res_to_bootmem?

reserve_bootmem_generic is some smart than reserve_bootmem when numa is enabled.

YH

commit 3f3040c347653b93e4e82ee45bb7d41f11c10be8
Author: Ingo Molnar <mingo@...e.hu>
Date:   Mon Jun 9 15:12:20 2008 +0200

    x86: reserve highmem pages via reserve_early, fix #2

    fix:

    arch/x86/kernel/built-in.o: In function `early_res_to_bootmem':
    : undefined reference to `reserve_bootmem_generic'

    Signed-off-by: Ingo Molnar <mingo@...e.hu>

diff --git a/arch/x86/kernel/e820.c b/arch/x86/kernel/e820.c
index a488bd0..68aba41 100644
--- a/arch/x86/kernel/e820.c
+++ b/arch/x86/kernel/e820.c
@@ -635,7 +635,7 @@ void __init early_res_to_bootmem(u64 start, u64 end)
                        continue;
                printk(KERN_INFO "  early res: %d [%llx-%llx] %s\n", i,
                        final_start, final_end - 1, r->name);
-               reserve_bootmem_generic(final_start, final_end - final_start,
+               reserve_bootmem(final_start, final_end - final_start,
                                BOOTMEM_DEFAULT);
        }
 }

commit df10637c5d57c2c1b42aeb2233e00da9764fd873
Author: Ingo Molnar <mingo@...e.hu>
Date:   Mon Jun 9 15:05:26 2008 +0200

    x86: reserve highmem pages via reserve_early, fix

    fix:

    arch/x86/kernel/e820.c: In function 'early_res_to_bootmem':
    arch/x86/kernel/e820.c:639: error: too few arguments to function
'reserve_bootmem_generic'

    Signed-off-by: Ingo Molnar <mingo@...e.hu>

diff --git a/arch/x86/kernel/e820.c b/arch/x86/kernel/e820.c
index a706e90..a488bd0 100644
--- a/arch/x86/kernel/e820.c
+++ b/arch/x86/kernel/e820.c
@@ -635,12 +635,8 @@ void __init early_res_to_bootmem(u64 start, u64 end)
                        continue;
                printk(KERN_INFO "  early res: %d [%llx-%llx] %s\n", i,
                        final_start, final_end - 1, r->name);
-#ifdef CONFIG_X86_64
-               reserve_bootmem_generic(final_start, final_end - final_start);
-#else
-               reserve_bootmem(final_start, final_end - final_start,
+               reserve_bootmem_generic(final_start, final_end - final_start,
                                BOOTMEM_DEFAULT);
-#endif
        }
 }
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/