linux-kernel - Re: [PATCH 4/8] atmel_nand: Clean up and fix probe() error path

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <cd73a99e0806091317q37d134acu8b7d4033e769fcc1@mail.gmail.com>
Date:	Mon, 9 Jun 2008 22:17:12 +0200
From:	"Andrew Victor" <avictor.za@...il.com>
To:	"Richard Genoud" <richard.genoud@...il.com>
Cc:	"Haavard Skinnemoen" <haavard.skinnemoen@...el.com>,
	linux-mtd@...ts.infradead.org, kernel@...32linux.org,
	"Nicolas Ferre" <nicolas.ferre@...el.com>,
	"Patrice VILCHEZ" <patrice.vilchez@...el.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 4/8] atmel_nand: Clean up and fix probe() error path

hi,

>> Then the driver can do
>>        if (host->board->ecc_regs)
>>                host->ecc = host->board->ecc_regs;
>>        else if (regs)
>>                host->ecc = ioremap(regs->start, regs->end - regs->start + 1);
>>
>>        if (hard_ecc && !host->ecc)
>>                printk("Hardware ECC not available\n");
>>
>> Right? I think we use a similar trick in the atmel_serial driver too.
>
> It may be the best solution indeed.

Agreed.


Regards,
  Andrew Victor
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/