linux-kernel - Re: [Patch 09/18] base xpc_rsvd

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20080608171537.eaf597d2.akpm@linux-foundation.org>
Date:	Sun, 8 Jun 2008 17:15:37 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Dean Nelson <dcn@....com>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [Patch 09/18] base xpc_rsvd_page's timestamp on jiffies

On Fri, 6 Jun 2008 11:52:16 -0500 Dean Nelson <dcn@....com> wrote:

> +	unsigned long stamp;	/* time when reserved page was setup by XPC */

"time" is a rubbery concept in-kernel.  What are the units of this? 
microseconds?  jiffies?  seconds?

At the least, the covering comment should make clear what units this
variable is using.  Better would be to actually embed the units in the
variable's identifier.  Because it's awfulyl easy to make mistakes over
this, and not knowing the units makes the code harder to follow.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/