linux-kernel - Re: [patch 12/21] perfmon2 minimal: sysfs interface

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080611144955.GA20145@kroah.com>
Date:	Wed, 11 Jun 2008 07:49:55 -0700
From:	Greg KH <greg@...ah.com>
To:	eranian@...glemail.com
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [patch 12/21] perfmon2 minimal:  sysfs interface

On Mon, Jun 09, 2008 at 03:34:25PM -0700, eranian@...glemail.com wrote:
> +
> +static struct kobject pfm_kernel_kobj;

Eeek, no, please look at Documentation/kobject.txt that says to not ever
have static kobjects.

I think a lot of this code can be cleaned up and shrunk given the way
that kobjects have changed recently.  See the examples in
samples/kobject/ and the documentation file for more details.

If you have any questions about it, please let me know.

Also, whenever you add a sysfs file to the kernel, please document it in
Documentation/ABI/ so that everyone knows what it is and how to use it.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/