lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 11 Jun 2008 17:00:34 +0200 From: "stephane eranian" <eranian@...glemail.com> To: "Greg KH" <greg@...ah.com> Cc: linux-kernel@...r.kernel.org Subject: Re: [patch 12/21] perfmon2 minimal: sysfs interface Greg, On Wed, Jun 11, 2008 at 4:49 PM, Greg KH <greg@...ah.com> wrote: > On Mon, Jun 09, 2008 at 03:34:25PM -0700, eranian@...glemail.com wrote: >> + >> +static struct kobject pfm_kernel_kobj; > > Eeek, no, please look at Documentation/kobject.txt that says to not ever > have static kobjects. > Will do. > I think a lot of this code can be cleaned up and shrunk given the way > that kobjects have changed recently. See the examples in > samples/kobject/ and the documentation file for more details. > If you say so. When building the series, I also wondered why there was so much code in there. But it was not clear to me how it could be shrunk. I saw some simplifications in 2.6.26 but still a lot of small functions. > If you have any questions about it, please let me know. > > Also, whenever you add a sysfs file to the kernel, please document it in > Documentation/ABI/ so that everyone knows what it is and how to use it. > I have that in my GIT tree. I simply forgot to include them in the quilt series. I will fix that. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists