linux-kernel - Re: [patch 12/21] perfmon2 minimal: sysfs interface

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7c86c4470806120554w38a11307qa34511cf4f8b4aba@mail.gmail.com>
Date:	Thu, 12 Jun 2008 14:54:15 +0200
From:	"stephane eranian" <eranian@...glemail.com>
To:	"Greg KH" <greg@...ah.com>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [patch 12/21] perfmon2 minimal: sysfs interface

Greg,

I looked at the documentation and the examples.

Find attached an updated version of the perfmon-sysfs.diff patch.

I have grouped attribute functions into common show/store functions
with a strcmp on
the attribute name. I have also used the kobject_init_and_add() function.

Once thing still confusing to me is the business with kobject_put()
after a kobject_init_and_add().
Is that necessary to drop the ref count to zero?

Also when you link to a parent,  like this:
	pfm_kernel_kobj = kobject_create_and_add("perfmon", kernel_kobj);

Does this increment the ref count on the parent?

In any case, let me know if there are still things that must be
changed/simplified in my file.

Thanks.

Download attachment "perfmon-sysfs.diff" of type "application/octet-stream" (16486 bytes)