linux-kernel - Re: [patch 12/21] perfmon2 minimal: sysfs interface

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 12 Jun 2008 20:50:55 -0700
From:	Greg KH <greg@...ah.com>
To:	eranian@...il.com
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [patch 12/21] perfmon2 minimal: sysfs interface

On Thu, Jun 12, 2008 at 02:54:15PM +0200, stephane eranian wrote:
> Greg,
> 
> I looked at the documentation and the examples.
> 
> Find attached an updated version of the perfmon-sysfs.diff patch.
> 
> I have grouped attribute functions into common show/store functions
> with a strcmp on
> the attribute name. I have also used the kobject_init_and_add() function.
> 
> Once thing still confusing to me is the business with kobject_put()
> after a kobject_init_and_add().
> Is that necessary to drop the ref count to zero?

Yes.

> Also when you link to a parent,  like this:
> 	pfm_kernel_kobj = kobject_create_and_add("perfmon", kernel_kobj);
> 
> Does this increment the ref count on the parent?

Yes.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/