linux-kernel - Re: [PATCH] kprobes: remove redundant config check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080611035955.GA19154@in.ibm.com>
Date:	Wed, 11 Jun 2008 09:29:55 +0530
From:	Ananth N Mavinakayanahalli <ananth@...ibm.com>
To:	Abhishek Sagar <sagar.abhishek@...il.com>
Cc:	LKML <linux-kernel@...r.kernel.org>,
	Masami Hiramatsu <mhiramat@...hat.com>,
	akpm@...ux-foundation.org
Subject: Re: [PATCH] kprobes: remove redundant config check

On Tue, Jun 10, 2008 at 10:43:02PM +0530, Abhishek Sagar wrote:
> Hi,
> 
> I noticed that there's a CONFIG_KPROBES check inside kernel/kprobes.c,
> which seems redundant. Can be removed?
> 
> Diff'd against v2.6.26-rc5.
> 
> 
> Signed-off-by: Abhishek Sagar <sagar.abhishek@...il.com>
> ---
> remove redundant CONFIG_KPROBES check.
> 
> diff --git a/kernel/kprobes.c b/kernel/kprobes.c
> index 1e0250c..2b2cae2 100644
> --- a/kernel/kprobes.c
> +++ b/kernel/kprobes.c
> @@ -1283,13 +1283,8 @@ EXPORT_SYMBOL_GPL(register_jprobe);
>  EXPORT_SYMBOL_GPL(unregister_jprobe);
>  EXPORT_SYMBOL_GPL(register_jprobes);
>  EXPORT_SYMBOL_GPL(unregister_jprobes);
> -#ifdef CONFIG_KPROBES
>  EXPORT_SYMBOL_GPL(jprobe_return);
> -#endif
> -
> -#ifdef CONFIG_KPROBES
>  EXPORT_SYMBOL_GPL(register_kretprobe);
>  EXPORT_SYMBOL_GPL(unregister_kretprobe);
>  EXPORT_SYMBOL_GPL(register_kretprobes);
>  EXPORT_SYMBOL_GPL(unregister_kretprobes);
> -#endif

Abhishek,

This was intentional (to take care of some gcc 4.2 issues). See commit
cd5bfea278987ebfe60f3ff92a01696b17c4f978 (fix compilation with gcc 4.2)
from Peter Chubb for details.

Ananth
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/