linux-kernel - Re: [PATCH] kprobes: remove redundant config check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <863e9df20806102253p4161e5bfv96ecc8ac5b4f9a89@mail.gmail.com>
Date:	Wed, 11 Jun 2008 11:23:54 +0530
From:	"Abhishek Sagar" <sagar.abhishek@...il.com>
To:	ananth@...ibm.com
Cc:	LKML <linux-kernel@...r.kernel.org>,
	"Masami Hiramatsu" <mhiramat@...hat.com>, akpm@...ux-foundation.org
Subject: Re: [PATCH] kprobes: remove redundant config check

On 6/11/08, Ananth N Mavinakayanahalli <ananth@...ibm.com> wrote:
> Abhishek,
>
>  This was intentional (to take care of some gcc 4.2 issues). See commit
>  cd5bfea278987ebfe60f3ff92a01696b17c4f978 (fix compilation with gcc 4.2)
>  from Peter Chubb for details.

Yea, I checked it out and the problem the commit seems to be fixing is that
EXPORT_SYMBOL  complains for static symbols with gcc-4.2. Can't see why
there was a need to cram CONFIG_KPROBES inside kprobes.c. This
check was sneaked in defensively it seems, and is unnecessary.

--
Regards,
Abhishek Sagar
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/