linux-kernel - Re: [PATCH] console keyboard mapping broken by 04c71976

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20080611182706.f8e2cc8c.akpm@linux-foundation.org>
Date:	Wed, 11 Jun 2008 18:27:06 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Samuel Thibault <samuel.thibault@...-lyon.org>
Cc:	Jiri Bohac <jbohac@...e.cz>, lkml <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] console keyboard mapping broken by 04c71976

On Thu, 12 Jun 2008 02:18:32 +0100 Samuel Thibault <samuel.thibault@...-lyon.org> wrote:

> 
> Ok, a closer look agrees with the patch, but no need to keep the uni
> variable then, here is an updated patch.  Thanks!
> 
> From: Jiri Bohac <jbohac@...e.cz>
> Signed-off-by: Samuel Thibault <samuel.thibault@...-lyon.org>
> 
> diff --git a/drivers/char/keyboard.c b/drivers/char/keyboard.c
> index 7f7e798..16492b7 100644
> --- a/drivers/char/keyboard.c
> +++ b/drivers/char/keyboard.c
> @@ -678,10 +678,5 @@
>  static void k_self(struct vc_data *vc, unsigned char value, char up_flag)
>  {
> -	unsigned int uni;
> -	if (kbd->kbdmode == VC_UNICODE)
> -		uni = value;
> -	else
> -		uni = conv_8bit_to_uni(value);
> -	k_unicode(vc, uni, up_flag);
> +	k_unicode(vc, conv_8bit_to_uni(value), up_flag);
>  }

Is this ready to be applied?  If so, please send a changelog.

btw, the From: line shold be right at the top of the changelog.

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/