linux-kernel - Re: [PATCH] console keyboard mapping broken by 04c71976

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20080612013611.GP4718@implementation>
Date:	Thu, 12 Jun 2008 02:36:11 +0100
From:	Samuel Thibault <samuel.thibault@...-lyon.org>
To:	Andrew Morton <akpm@...ux-foundation.org>
Cc:	Jiri Bohac <jbohac@...e.cz>, lkml <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] console keyboard mapping broken by 04c71976

Andrew Morton, le Wed 11 Jun 2008 18:27:06 -0700, a écrit :
> Is this ready to be applied?  If so, please send a changelog.

Ah, right, there was no changelog.



From: Jiri Bohac <jbohac@...e.cz>

Several console keyboard maps are broken since 04c71976, because that
changeset made k_self consider the value as a latin1 character when in
Unicode mode, which is wrong; k_self should still take the console map
into account.

Signed-off-by: Samuel Thibault <samuel.thibault@...-lyon.org>

diff --git a/drivers/char/keyboard.c b/drivers/char/keyboard.c
index 7f7e798..16492b7 100644
--- a/drivers/char/keyboard.c
+++ b/drivers/char/keyboard.c
@@ -678,10 +678,5 @@
 static void k_self(struct vc_data *vc, unsigned char value, char up_flag)
 {
-	unsigned int uni;
-	if (kbd->kbdmode == VC_UNICODE)
-		uni = value;
-	else
-		uni = conv_8bit_to_uni(value);
-	k_unicode(vc, uni, up_flag);
+	k_unicode(vc, conv_8bit_to_uni(value), up_flag);
 }
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/