linux-kernel - Re: [KERNEL 2.6.26-rc4] bugreport : pata

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20080614213612.96873c25.komurojun-mbn@nifty.com>
Date:	Sat, 14 Jun 2008 21:36:12 +0900
From:	Komuro <komurojun-mbn@...ty.com>
To:	Jeff Garzik <jeff@...zik.org>
Cc:	Tejun Heo <htejun@...il.com>,
	Dominik Brodowski <linux@...inikbrodowski.net>,
	jgarzik@...hat.com, linux-ide@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	linux-pcmcia <linux-pcmcia@...ts.infradead.org>,
	Kristoffer Ericson <kristoffer.ericson@...il.com>
Subject: Re: [KERNEL 2.6.26-rc4]  bugreport : pata_pcmcia with Sandisk
 Extreme III 8GB

On Sat, 14 Jun 2008 03:20:41 -0400
Jeff Garzik <jeff@...zik.org> wrote:


After removing the 3-lines below in ata_eh_reset
the pata_pcmcia works properly.


-       spin_lock_irqsave(link->ap->lock, flags);
-       link->eh_info.serror = 0;
-       spin_unlock_irqrestore(link->ap->lock, flags);

Please fix this problem.

Best Regards
Komuro


> > 
> >>>>>> pcmcia: registering new device pcmcia1.1
> >>>>>> 1.1: GetNextTuple: No more items
> >>>>>> pata_pcmcia: probe of 1.1 failed with error -12
> > 
> > The patch "libata: kill hotplug related race condition"
> > introduced the pata_pcmcia error.
> > 
> > Please fix this problem.
> > 
> > 
> > Best Regards
> > Komuro
> > 
> >>> f046519fc85a8fdf6a058b4ac9d897cdee6f3e52 is first bad commit
> > commit f046519fc85a8fdf6a058b4ac9d897cdee6f3e52
> > Author: Tejun Heo <htejun@...il.com>
> > Date:   Mon May 19 01:15:08 2008 +0900
> > 
> >     libata: kill hotplug related race condition
> >     
> >     Originally, whole reset processing was done while the port is frozen
> >     and SError was cleared during @postreset().  This had two race
> >     conditions.  1: hotplug could occur after reset but before SError is
> >     cleared and libata won't know about it.  2: hotplug could occur after
> >     all the reset is complete but before the port is thawed.  As all
> >     events are cleared on thaw, the hotplug event would be lost.
> 
> Interesting!  Thanks for the diagnosis...
> 
> 	Jeff
> 
> 
> 


-- 
Komuro <komurojun-mbn@...ty.com>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/