linux-kernel - Re: [KERNEL 2.6.26-rc4] bugreport : pata

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4855D8E2.10409@gmail.com>
Date:	Mon, 16 Jun 2008 12:07:14 +0900
From:	Tejun Heo <htejun@...il.com>
To:	Komuro <komurojun-mbn@...ty.com>
CC:	Jeff Garzik <jeff@...zik.org>,
	Dominik Brodowski <linux@...inikbrodowski.net>,
	jgarzik@...hat.com, linux-ide@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	linux-pcmcia <linux-pcmcia@...ts.infradead.org>,
	Kristoffer Ericson <kristoffer.ericson@...il.com>
Subject: Re: [KERNEL 2.6.26-rc4]  bugreport : pata_pcmcia with Sandisk Extreme
 III 8GB

Hello,

Komuro wrote:
> On Sat, 14 Jun 2008 03:20:41 -0400
> Jeff Garzik <jeff@...zik.org> wrote:
> 
> 
> After removing the 3-lines below in ata_eh_reset
> the pata_pcmcia works properly.
> 
> 
> -       spin_lock_irqsave(link->ap->lock, flags);
> -       link->eh_info.serror = 0;
> -       spin_unlock_irqrestore(link->ap->lock, flags);
> 
> Please fix this problem.

Thanks for diagnosing the problem but it doesn't make any sense at all.
 Those three lines just clear cached SError value.  pata_pcmcia being a
PATA driver, SError is not implemented and always zero.

Also the init_one error is -ENOMEM.  For the above change to make any
difference, EH should have been entered which is invoked deep into
ata_host_register() and once control reaches that point it never returns
error code.  I have difficult time imagining any way the above diff can
have anything to do with the reported failure.

Please apply the attached patch and report the log after probe failure.

Thanks.

-- 
tejun

View attachment "pata_pcmcia-debug.patch" of type "text/x-patch" (1777 bytes)