linux-kernel - Re: [KERNEL 2.6.26-rc4] bugreport : pata

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 16 Jun 2008 22:11:45 +0900
From:	Komuro <komurojun-mbn@...ty.com>
To:	Tejun Heo <htejun@...il.com>
Cc:	Jeff Garzik <jeff@...zik.org>,
	Dominik Brodowski <linux@...inikbrodowski.net>,
	jgarzik@...hat.com, linux-ide@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	linux-pcmcia <linux-pcmcia@...ts.infradead.org>,
	Kristoffer Ericson <kristoffer.ericson@...il.com>
Subject: Re: [KERNEL 2.6.26-rc4]  bugreport : pata_pcmcia with Sandisk
 Extreme III 8GB

Hi,

Here is the log  (your patch is applied).
Unfortunately, no message that you added appears.

It seems this device is detected as pcmcia0.0 first
but later it is detected as pcmcia0.1.


>pcmcia: registering new device pcmcia0.0
>scsi2 : pata_pcmcia
>ata3: PATA max PIO0 cmd 0xd100 ctl 0xd10e irq 4
>ata3.00: CFA: , Ver.1.0, max PIO2
>ata3.00: 32000 sectors, multi 0: LBA 
>ata3.00: configured for PIO0
>ata3.00: configured for PIO0
>ata3: EH complete
>isa bounce pool size: 16 pages
>scsi 2:0:0:0: Direct-Access     ATA                       Ver. PQ: 0 ANSI: 5
>sd 2:0:0:0: [sdb] 32000 512-byte hardware sectors (16 MB)
>sd 2:0:0:0: [sdb] Write Protect is off
>sd 2:0:0:0: [sdb] Mode Sense: 00 3a 00 00
>sd 2:0:0:0: [sdb] Write cache: disabled, read cache: enabled, doesn't support DPO or FUA
>sd 2:0:0:0: [sdb] 32000 512-byte hardware sectors (16 MB)
>sd 2:0:0:0: [sdb] Write Protect is off
>sd 2:0:0:0: [sdb] Mode Sense: 00 3a 00 00
>sd 2:0:0:0: [sdb] Write cache: disabled, read cache: enabled, doesn't support DPO or FUA
> sdb: sdb1
>sd 2:0:0:0: [sdb] Attached SCSI removable disk
>sd 2:0:0:0: Attached scsi generic sg2 type 0
>pcmcia: registering new device pcmcia0.1
>pcmcia: registering new device pcmcia0.1
>0.1: GetNextTuple: No more items
>pata_pcmcia: probe of 0.1 failed with error -12
>modprobe used greatest stack depth: 1684 bytes left
>0.1: GetNextTuple: No more items
>pata_pcmcia: probe of 0.1 failed with error -12
>0.1: GetNextTuple: No more items
>pata_pcmcia: probe of 0.1 failed with error -12

Best Regards
Komuro

> Hello,
> 
> Komuro wrote:
> > On Sat, 14 Jun 2008 03:20:41 -0400
> > Jeff Garzik <jeff@...zik.org> wrote:
> > 
> > 
> > After removing the 3-lines below in ata_eh_reset
> > the pata_pcmcia works properly.
> > 
> > 
> > -       spin_lock_irqsave(link->ap->lock, flags);
> > -       link->eh_info.serror = 0;
> > -       spin_unlock_irqrestore(link->ap->lock, flags);
> > 
> > Please fix this problem.
> 
> Thanks for diagnosing the problem but it doesn't make any sense at all.
>  Those three lines just clear cached SError value.  pata_pcmcia being a
> PATA driver, SError is not implemented and always zero.
> 
> Also the init_one error is -ENOMEM.  For the above change to make any
> difference, EH should have been entered which is invoked deep into
> ata_host_register() and once control reaches that point it never returns
> error code.  I have difficult time imagining any way the above diff can
> have anything to do with the reported failure.
> 
> Please apply the attached patch and report the log after probe failure.
> 
> Thanks.
> 
> -- 
> tejun
> 


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/