linux-kernel - Re: [patch 01/15] MMC: S3C24XX MMC/SD driver. From: Thomas Kleffel <tk@...ntech.de>

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 14 Jun 2008 18:18:51 +0200
From:	Pierre Ossman <drzeus@...eus.cx>
To:	Ben Dooks <ben-linux@...ff.org>
Cc:	linux-kernel@...r.kernel.org, Harald Welte <laforge@...nmoko.org>,
	Thomas Kleffel <tk@...ntech.de>,
	Roman Moravcik <roman.moravcik@...il.com>,
	Ben Dooks <ben-linux@...ff.org>
Subject: Re: [patch 01/15] MMC: S3C24XX MMC/SD driver. From: Thomas Kleffel
 <tk@...ntech.de>

On Fri, 06 Jun 2008 16:51:18 +0100
Ben Dooks <ben-linux@...ff.org> wrote:

> +#include <linux/mmc/mmc.h>

You don't need this anymore.

> +	//if(cmd->flags & MMC_RSP_MAYFAIL) debug_as_failure = 0;

Please remove all the dead code.

> +	if (mrq->data->error == MMC_ERR_NONE) {

And rebase against HEAD. MMC_ERR_* are long gone.

Also, please test using the mmc_test driver available in HEAD. A proper
driver should pass all those tests (or possibly mark a few as
unsupported if the hardware is utterly incapable of handling those
requests).

Rgds
Pierre

Download attachment "signature.asc" of type "application/pgp-signature" (198 bytes)