linux-kernel - Re: [patch 05/15] MMC: Fix S3C24XX IRQ enable during PIO transfers From: Roman Moracik <roman.moravcik@...il.com>

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080614182024.03422126@mjolnir.drzeus.cx>
Date:	Sat, 14 Jun 2008 18:20:24 +0200
From:	Pierre Ossman <drzeus@...eus.cx>
To:	Ben Dooks <ben-linux@...ff.org>
Cc:	linux-kernel@...r.kernel.org, Harald Welte <laforge@...nmoko.org>,
	Thomas Kleffel <tk@...ntech.de>,
	Roman Moravcik <roman.moravcik@...il.com>,
	Ben Dooks <ben-linux@...ff.org>
Subject: Re: [patch 05/15] MMC: Fix S3C24XX IRQ enable during PIO transfers
 From: Roman Moracik <roman.moravcik@...il.com>

On Fri, 06 Jun 2008 16:51:22 +0100
Ben Dooks <ben-linux@...ff.org> wrote:

> Fix Bug #677 - I/O errors on heavy microSD writes for 2.6.22.x.
> 
> Signed-off-by: Ben Dooks <ben-linux@...ff.org>
> 
> Index: linux-2.6.26-rc5-q/drivers/mmc/host/s3cmci.c
> ===================================================================
> --- linux-2.6.26-rc5-q.orig/drivers/mmc/host/s3cmci.c	2008-06-06 15:46:01.000000000 +0100
> +++ linux-2.6.26-rc5-q/drivers/mmc/host/s3cmci.c	2008-06-06 15:46:03.000000000 +0100
> @@ -313,6 +313,7 @@ static void pio_tasklet(unsigned long da
>  {
>  	struct s3cmci_host *host = (struct s3cmci_host *) data;
>  
> +	disable_irq(host->irq);
>  

This seems harsh. Can't you just fiddle with the interrupt mask of this
specific device?

Download attachment "signature.asc" of type "application/pgp-signature" (198 bytes)