[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20080614182220.69474ac5@mjolnir.drzeus.cx>
Date: Sat, 14 Jun 2008 18:22:20 +0200
From: Pierre Ossman <drzeus@...eus.cx>
To: Ben Dooks <ben-linux@...ff.org>
Cc: linux-kernel@...r.kernel.org, Harald Welte <laforge@...nmoko.org>,
Thomas Kleffel <tk@...ntech.de>,
Roman Moravcik <roman.moravcik@...il.com>,
Ben Dooks <ben-linux@...ff.org>
Subject: Re: [patch 06/15] MMC: Add platform data for S3C24XX MMC/SD driver
On Fri, 06 Jun 2008 16:51:23 +0100
Ben Dooks <ben-linux@...ff.org> wrote:
> This patch adds platform data support to the s3mci driver. This allows
> flexible board-specific configuration of set_power, card detect and read only
> pins.
>
> Signed-off-by: Ben Dooks <ben-linux@...ff.org>
>
Please see the changes in my #next branch where you can return -ENOSYS
to indicate that you do not know the state of the read only pin.
> +
> +static struct s3c24xx_mci_pdata s3cmci_def_pdata = {
> + .gpio_detect = 0,
> + .set_power = NULL,
> + .ocr_avail = MMC_VDD_32_33,
> };
You probably want MMC_VDD_32_32 | MMC_VDD_33_34 here.
Download attachment "signature.asc" of type "application/pgp-signature" (198 bytes)
Powered by blists - more mailing lists