linux-kernel - Re: [PATCH] gigaset: fix module reference counting

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4855A145.90803@imap.cc>
Date:	Mon, 16 Jun 2008 01:09:57 +0200
From:	Tilman Schmidt <tilman@...p.cc>
To:	Andreas Herrmann <aherrman@...or.de>
CC:	Hansjoerg Lipp <hjlipp@....de>,
	gigaset307x-common@...ts.sourceforge.net,
	linux-kernel@...r.kernel.org,
	Andrew Morton <akpm@...ux-foundation.org>, kkeil@...e.de
Subject: Re: [PATCH] gigaset: fix module reference counting

Hi Andreas,

On 2008-06-07 00:39, Andreas Herrmann wrote:
> bas_gigaset can't be unloaded due to wrong module reference counting.
> Ensure that module_put is called whenever a channel is freed.

I'm not quite happy with that patch. Specifically, I see a risk of
module_put being called too often.

Could you explain in some more detail what bug you are trying to fix?
Do you have a sequence of events which leads to a situation where the
bas_gigaset module cannot be unloaded but should be?

Thanks,
Tilman

Download attachment "signature.asc" of type "application/pgp-signature" (255 bytes)