linux-kernel - Re: [PATCH] gigaset: fix module reference counting

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 23 Jun 2008 09:32:27 +0200
From:	Andreas Herrmann <aherrman@...or.de>
To:	Tilman Schmidt <tilman@...p.cc>
Cc:	Hansjoerg Lipp <hjlipp@....de>,
	gigaset307x-common@...ts.sourceforge.net,
	linux-kernel@...r.kernel.org,
	Andrew Morton <akpm@...ux-foundation.org>, kkeil@...e.de
Subject: Re: [PATCH] gigaset: fix module reference counting

On Mon, Jun 16, 2008 at 01:09:57AM +0200, Tilman Schmidt wrote:
> On 2008-06-07 00:39, Andreas Herrmann wrote:
> > bas_gigaset can't be unloaded due to wrong module reference counting.
> > Ensure that module_put is called whenever a channel is freed.
> 
> I'm not quite happy with that patch. Specifically, I see a risk of
> module_put being called too often.

> Could you explain in some more detail what bug you are trying to fix?
> Do you have a sequence of events which leads to a situation where the
> bas_gigaset module cannot be unloaded but should be?

I've tried to reproduce the problem doing various tests -- but without
success.

Then i've checked the code and there was already this fix:

commit e468c04894f36045cf93d1384183a461014b6840 (Gigaset: permit module unload)

This was commited after 2.6.24 was released.

And (shit happens!) on the machine where I've previously tested the
stuff I had also an 2.6.24 kernel installed.

So it seems that I have mixed up different kernel versions when I've
tested my patch. Because with current git-tree bas_gigaset can be
unloaded without any problems.

Sorry for the noise.


Regards,

Andreas

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/