linux-kernel - Re: [PATCH] [RFC v3] OF: OpenFirmware bindings for the mmc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <fa686aa40806160713q51f3d132w2fef2a2473faad1@mail.gmail.com>
Date:	Mon, 16 Jun 2008 08:13:06 -0600
From:	"Grant Likely" <grant.likely@...retlab.ca>
To:	"Pierre Ossman" <drzeus-mmc@...eus.cx>
Cc:	"Anton Vorontsov" <avorontsov@...mvista.com>,
	"David Brownell" <dbrownell@...rs.sourceforge.net>,
	"Jochen Friedrich" <jochen@...am.de>,
	"Segher Boessenkool" <segher@...nel.crashing.org>,
	"Gary Jennejohn" <garyj@...x.de>,
	"Guennadi Liakhovetski" <g.liakhovetski@....de>,
	linuxppc-dev@...abs.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] [RFC v3] OF: OpenFirmware bindings for the mmc_spi driver

On Sat, Jun 14, 2008 at 9:57 AM, Pierre Ossman <drzeus-mmc@...eus.cx> wrote:
> On Thu, 5 Jun 2008 20:16:24 +0400
> Anton Vorontsov <avorontsov@...mvista.com> wrote:
>
>> Here is v3. I'm out of ideas if you won't like it. :-)
>>
>> v3:
>> - Now these bindings are using bus notifiers chain, thus we adhere to the
>>   spi bus.
>>
>
> Now this was nice and clean. I take it Grant doesn't like this version
> though. What's the downside of it?

No, I don't.  I like the v2 approach better as long as it is been
changed to address your comments.  This approach I think is needlessly
complex and non-obvious (relying on the notification chain instead of
being part of the probe call).  It will break in non-obvious ways if
the notifier module is loaded after the mmc_spi driver.

Cheers,
g.

-- 
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/