linux-kernel - [PATCH 0/3] resend, ptrace && SIGKILL fixes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20080616142016.GA13339@tv-sign.ru>
Date:	Mon, 16 Jun 2008 18:20:16 +0400
From:	Oleg Nesterov <oleg@...sign.ru>
To:	Andrew Morton <akpm@...ux-foundation.org>
Cc:	Ingo Molnar <mingo@...e.hu>, Matthew Wilcox <matthew@....cx>,
	Roland McGrath <roland@...hat.com>,
	linux-kernel@...r.kernel.org
Subject: [PATCH 0/3] resend, ptrace && SIGKILL fixes

On 06/10, Oleg Nesterov wrote:
>
> These 2 patches don't depend on each other. Each change is user visible,
> and I am not really sure it can't confuse debuggers/etc. The explicit
> ack/nack from maintainers is wanted.

I'm mostly worried about do_exit()->ptrace_notify(), with these patches
we never notify the tracer if the tracee was SIGKILL'ed. The current
behaviour depends on arch_ptrace_stop_needed(), this is not good either.

Anyway, I think these patches are fixes. Suppose we send SIGKILL to the
traced task which does ptrace_notify(). If the signal is delivered before
ptrace_notify() takes ->siglock, the tracee sleeps in TASK_TRACED state
and becomes "unkillable". If ptrace_notify() wins, we kill the tracee.
This can't be good.

The 3rd patch is new.

Oleg.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/