linux-kernel - Re: [patch] aio: invalidate async directio writes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080618182223.GA14851@infradead.org>
Date:	Wed, 18 Jun 2008 14:22:23 -0400
From:	Christoph Hellwig <hch@...radead.org>
To:	Jeff Moyer <jmoyer@...hat.com>
Cc:	akpm@...ux-foundation.org, zach.brown@...cle.com,
	linux-aio@...ck.org, linux-kernel@...r.kernel.org
Subject: Re: [patch] aio: invalidate async directio writes

On Wed, Jun 18, 2008 at 02:09:51PM -0400, Jeff Moyer wrote:
> +		/* For async O_DIRECT writes, we need to invalidate the 
> +		 * page cache after the write completes.  Kick off a
> +		 * workqueue to do this and issue the completion in process
> +		 * context.
> +		 */
> +		if (dio->rw == READ) {
> +			int ret = dio_complete(dio, dio->iocb->ki_pos, 0);
> +			aio_complete(dio->iocb, ret, 0);
> +			kfree(dio);
> +		} else {
> +			unsigned long flags;
> +			spin_lock_irqsave(&iocb_completion_list_lock, flags);
> +			list_add(&dio->done_list, &iocb_completion_list);
> +			spin_unlock_irqrestore(&iocb_completion_list_lock, flags);
> +			schedule_work(&aio_complete_work);
> +		}

Can we please move all these aio_complete calls to user context?  Having
AIO contexts completing from irq context is a major pain for complex
filesystems like XFS.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/