linux-kernel - Re: mce_64.c: mce_cpu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <485ACCA1.6070507@firstfloor.org>
Date:	Thu, 19 Jun 2008 23:16:17 +0200
From:	Andi Kleen <andi@...stfloor.org>
To:	Max Asbock <masbock@...ibm.com>
CC:	lkml <linux-kernel@...r.kernel.org>, venkatesh.pallipadi@...el.com
Subject: Re: mce_64.c: mce_cpu_quirks being ignored

Max Asbock wrote:



> static void __cpuinit mce_cpu_quirks(struct cpuinfo_x86 *c)
> {
>         /* This should be disabled by the BIOS, but isn't always */
>         if (c->x86_vendor == X86_VENDOR_AMD) {
>                 if(c->x86 == 15)
>                         /* disable GART TBL walk error reporting, which trips off
>                            incorrectly with the IOMMU & 3ware & Cerberus. */
>                         clear_bit(10, &bank[4]);
> ....
> 
> Is turning off that bit still needed?

Yes it is. Also referencing the bank is needed for other reasons anyways,
otherwise it would ignore the user sysfs choice on reconfiguration.

Venki, I did a patch for dynamic banks anyways, but haven't submitted it yet.

-Andi

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/