[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <485BFFC4.3070902@goop.org>
Date: Fri, 20 Jun 2008 12:06:44 -0700
From: Jeremy Fitzhardinge <jeremy@...p.org>
To: Ingo Molnar <mingo@...e.hu>
CC: Linus Torvalds <torvalds@...ux-foundation.org>,
benh@...nel.crashing.org,
xen-devel <xen-devel@...ts.xensource.com>,
Peter Zijlstra <a.p.zijlstra@...llo.nl>,
kvm-devel <kvm-devel@...ts.sourceforge.net>, x86@...nel.org,
LKML <linux-kernel@...r.kernel.org>,
Virtualization Mailing List <virtualization@...ts.osdl.org>,
Hugh Dickins <hugh@...itas.com>,
Thomas Gleixner <tglx@...utronix.de>
Subject: Re: [PATCH 1 of 4] mm: add a ptep_modify_prot transaction abstraction
Ingo Molnar wrote:
> * Ingo Molnar <mingo@...e.hu> wrote:
>
>
>> * Linus Torvalds <torvalds@...ux-foundation.org> wrote:
>>
>>
>>> On Thu, 19 Jun 2008, Ingo Molnar wrote:
>>>
>>>> Below is the commit, it needed a small amount of massaging to apply the
>>>> void * -> unsigned long * change in the x86/bitops topic.
>>>>
>>> Well, that's your bug right there.
>>>
>>> The macros very much depended on the pointers being "void *", due to
>>> the pointer arithmetic (which is a gcc extension that we use
>>> extensively - "void *" arithmetic works as if it was a byte
>>> pointer).
>>>
>> duh, yeah - of course. Will retry with that fixed :)
>>
>
> yep, the patch below got it all going and it passed 5 hours of testing
> already. Thanks,
>
Blows up on "gcc version 3.4.4 20050314 (prerelease) (Debian 3.4.3-13)":
CC init/main.o
include2/asm/bitops.h: In function `start_kernel':
include2/asm/bitops.h:59: warning: asm operand 1 probably doesn't match constraints
include2/asm/bitops.h:59: warning: asm operand 1 probably doesn't match constraints
include2/asm/bitops.h:59: warning: asm operand 1 probably doesn't match constraints
include2/asm/bitops.h:59: error: impossible constraint in `asm'
include2/asm/bitops.h:59: error: impossible constraint in `asm'
include2/asm/bitops.h:59: error: impossible constraint in `asm'
J
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists