linux-kernel - Re: [PATCH 33/60] microblaze

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200806261718.18006.arnd@arndb.de>
Date:	Thu, 26 Jun 2008 17:18:17 +0200
From:	Arnd Bergmann <arnd@...db.de>
To:	monstr@...nam.cz
Cc:	linux-kernel@...r.kernel.org, linux-arch@...r.kernel.org,
	stephen.neuendorffer@...inx.com, John.Linn@...inx.com,
	john.williams@...alogix.com, matthew@....cx, will.newton@...il.com,
	drepper@...hat.com, microblaze-uclinux@...e.uq.edu.au,
	grant.likely@...retlab.ca, linuxppc-dev@...abs.org,
	vapier.adi@...il.com, alan@...rguk.ukuu.org.uk, hpa@...or.com,
	Michal Simek <monstr@...str.eu>
Subject: Re: [PATCH 33/60] microblaze_v4: includes SHM*, msgbuf

On Thursday 26 June 2008, monstr@...nam.cz wrote:
>  include/asm-microblaze/msgbuf.h   |   39 ++++++++++++++++++++++++++++
>  include/asm-microblaze/shmbuf.h   |   50 +++++++++++++++++++++++++++++++++++++
>  include/asm-microblaze/shmparam.h |   14 ++++++++++
>  3 files changed, 103 insertions(+), 0 deletions(-)
>  create mode 100644 include/asm-microblaze/msgbuf.h
>  create mode 100644 include/asm-microblaze/shmbuf.h
>  create mode 100644 include/asm-microblaze/shmparam.h
> 

These files are ok, but IMHO they should be in asm-generic, since there
are already many identical copies.

While the implementation of these three, as well as ipcbuf.h and sembuf.h
could be better optimized for endianess and word size differences, I have
come to the conclusion that there is no point for them to really be
different, and uClibc expects this exact layout by default anyway.

	Arnd <><
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/