linux-kernel - Re: [PATCH 46/60] microblaze

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200806261728.48860.arnd@arndb.de>
Date:	Thu, 26 Jun 2008 17:28:47 +0200
From:	Arnd Bergmann <arnd@...db.de>
To:	monstr@...nam.cz
Cc:	linux-kernel@...r.kernel.org, linux-arch@...r.kernel.org,
	stephen.neuendorffer@...inx.com, John.Linn@...inx.com,
	john.williams@...alogix.com, matthew@....cx, will.newton@...il.com,
	drepper@...hat.com, microblaze-uclinux@...e.uq.edu.au,
	grant.likely@...retlab.ca, linuxppc-dev@...abs.org,
	vapier.adi@...il.com, alan@...rguk.ukuu.org.uk, hpa@...or.com,
	Michal Simek <monstr@...str.eu>
Subject: Re: [PATCH 46/60] microblaze_v4: termbits.h termios.h

On Thursday 26 June 2008, monstr@...nam.cz wrote:
> @@ -0,0 +1,84 @@
> +
> +#include <linux/string.h>
> +#include <asm/termbits.h>
> +#include <asm/ioctls.h>
> +
> +struct winsize {
> +       unsigned short ws_row;
> +       unsigned short ws_col;
> +       unsigned short ws_xpixel;
> +       unsigned short ws_ypixel;
> +};
> +
> +#define NCC 8
> +struct termio {
> +       unsigned short c_iflag; /* input mode flags */
> +       unsigned short c_oflag; /* output mode flags */
> +       unsigned short c_cflag; /* control mode flags */
> +       unsigned short c_lflag; /* local mode flags */
> +       unsigned char c_line; /* line discipline */
> +       unsigned char c_cc[NCC]; /* control characters */
> +};
> +
> +#ifdef __KERNEL__
> +/*     intr=^C         quit=^|         erase=del       kill=^U
> +       eof=^D          vtime=\0        vmin=\1         sxtc=\0
> +       start=^Q        stop=^S         susp=^Z         eol=\0
> +       reprint=^R      discard=^U      werase=^W       lnext=^V
> +       eol2=\0
> +*/
> +#define INIT_C_CC "\003\034\177\025\004\0\1\0\021\023\032\0\022\017\027\026\0"
> +#endif
> +
> +/* Modem lines */
> +
> +#define TIOCM_LE       0x001
> +#define TIOCM_DTR      0x002
> +#define TIOCM_RTS      0x004
> +#define TIOCM_ST       0x008
> +#define TIOCM_SR       0x010
> +#define TIOCM_CTS      0x020
> +#define TIOCM_CAR      0x040
> +#define TIOCM_RNG      0x080
> +#define TIOCM_DSR      0x100
> +#define TIOCM_CD       TIOCM_CAR
> +#define TIOCM_RI       TIOCM_RNG
> +#define TIOCM_OUT1     0x2000
> +#define TIOCM_OUT2     0x4000
> +#define TIOCM_LOOP     0x8000

It would be nice if more of the above could be in asm-generic/termios.h,
as far as I can tell they are identical for all (four) users of that
generic file.
Of course if you do that, you'll have to remove the code from the existing
users.

> +/* ioctl (fd, TIOCSERGETLSR, &result) where result may be as below */
> +
> +/* Line disciplines */
> +
> +#define N_TTY          0
> +#define N_SLIP         1
> +#define N_MOUSE                2
> +#define N_PPP          3
> +#define N_STRIP                4
> +#define N_AX25         5
> +#define N_X25          6 /* X.25 async */
> +#define N_6PACK                7
> +#define N_MASC         8 /* Reserved for Mobitex module <kaz@...e.net> */
> +#define N_R3964                9 /* Reserved for Simatic R3964 module */
> +#define N_PROFIBUS_FDL 10 /* Reserved for Profibus <Dave@...i.com> */
> +#define N_IRDA         11 /* Linux IR - http://irda.sourceforge.net/ */
> +#define N_SMSBLOCK     12 /* SMS block mode - for talking to GSM data cards
> +                               about SMS messages */
> +#define N_HDLC         13 /* synchronous HDLC */
> +#define N_SYNC_PPP     14
> +#define N_HCI          15 /* Bluetooth HCI UART */
> +

These are already defined in linux/tty.h, so they should not be here.

	Arnd <><