linux-kernel - Re: keyspan_pda.c use of keyspan_pda_get_modem

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080626162346.5c324701@lxorguk.ukuu.org.uk>
Date:	Thu, 26 Jun 2008 16:23:46 +0100
From:	Alan Cox <alan@...rguk.ukuu.org.uk>
To:	Benny Halevy <bhalevy@...asas.com>
Cc:	Greg KH <greg@...ah.com>, lkml <linux-kernel@...r.kernel.org>
Subject: Re: keyspan_pda.c use of keyspan_pda_get_modem_info

> In these two call sites the callers bail out if
> keyspan_pda_get_modem_info return value is < 0

I don't think that is what the compiler is warning about.

We error on rc < 0
We use the returned status on rc >= 0

We set the returned status on rc > 0

So the rc = 0 case is broken and gcc seems to be correct about that
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/