linux-kernel - Re: keyspan_pda.c use of keyspan_pda_get_modem

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080627041735.GB8145@kroah.com>
Date:	Thu, 26 Jun 2008 21:17:35 -0700
From:	Greg KH <greg@...ah.com>
To:	Alan Cox <alan@...rguk.ukuu.org.uk>
Cc:	Benny Halevy <bhalevy@...asas.com>,
	lkml <linux-kernel@...r.kernel.org>
Subject: Re: keyspan_pda.c use of keyspan_pda_get_modem_info

On Thu, Jun 26, 2008 at 04:23:46PM +0100, Alan Cox wrote:
> > In these two call sites the callers bail out if
> > keyspan_pda_get_modem_info return value is < 0
> 
> I don't think that is what the compiler is warning about.
> 
> We error on rc < 0
> We use the returned status on rc >= 0
> 
> We set the returned status on rc > 0
> 
> So the rc = 0 case is broken and gcc seems to be correct about that

Yes, that is correct, fortunatly that function can never return rc = 0,
so this will not happen in real life.

But there is really no way the compiler can ever figure that out, so I
don't blame it for complaining.

If you want to make a simple patch to make the compiler happy and be
quiet about the warning, I'll take it.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/