linux-kernel - Re: [PATCH 1/6] Extend completions to provide XFS object flush requirements

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080627022407.GB7703@parisc-linux.org>
Date:	Thu, 26 Jun 2008 20:24:07 -0600
From:	Matthew Wilcox <matthew@....cx>
To:	Daniel Walker <dwalker@...sta.com>
Cc:	Dave Chinner <david@...morbit.com>, xfs@....sgi.com,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/6] Extend completions to provide XFS object flush requirements

On Thu, Jun 26, 2008 at 01:33:25PM -0700, Daniel Walker wrote:
> I think there is some basis to make the changes that you have here.
> Specifically this email and thread,
> 
> http://lkml.org/lkml/2008/4/15/232

You've completely missed the point.  The current semaphore code is
_more_ efficient than the current completion code.  I'm very comfortable
having two APIs here, one for completion-like semantics and one for
mutex-like semantics.  Confusing them like this makes no sense at all.

> However, I don't like how your implementing this as specifically a
> "flush" mechanism for XFS, and the count is limited to just 1 .. There
> are several other places that do this kind of counting with semaphores,
> and have counts above 1..

Then leave them as semaphores.  Really.

-- 
Intel are signing my paycheques ... these opinions are still mine
"Bill, look, we understand that you're interested in selling us this
operating system, but compare it to ours.  We can't possibly take such
a retrograde step."
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/