linux-kernel - [PATCH]: libata-scsi: Don't start hotplug work queue if hotplug is disabled

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 27 Jun 2008 10:20:46 +0800
From:	Chunbo Luo <chunbo.luo@...driver.com>
To:	linux-kernel@...r.kernel.org
Cc:	jeff@...zik.org
Subject: [PATCH]: libata-scsi: Don't start hotplug work queue if hotplug is
	disabled

Hi

When ata_scsi_scan_host() scan device failed, it will start a work queue
unconditionally. This may cause some noisy messages. This patch fix this
problem.


---
commit 6c686a6814a805782c7ab48ad89352ee309e8c32
Author: Chunbo Luo <chunbo.luo@...driver.com>
Date:   Fri Jun 27 09:56:52 2008 +0800

    libata-scsi: Don't start hotplug work queue if hotplug is disabled
    
    Previously, queue_delayed_work() was started unconditionally, but if
    ATA_PFLAG_SCSI_HOTPLUG is not set and we do this, the work queue may
    cause multiple messages like this:
    
    ata3.00: WARNING: ATAPI is not supported with this driver, device ignored.
    
    So now,it is only started when the hotplug flag is actually set.
    
    Signed-off-by: Chunbo Luo <chunbo.luo@...driver.com>

diff --git a/drivers/ata/libata-scsi.c b/drivers/ata/libata-scsi.c
index 57a4364..7ed5bb3 100644
--- a/drivers/ata/libata-scsi.c
+++ b/drivers/ata/libata-scsi.c
@@ -3108,8 +3108,9 @@ void ata_scsi_scan_host(struct ata_port *ap, int sync)
                                "                  switching to async\n");
        }
 
-       queue_delayed_work(ata_aux_wq, &ap->hotplug_task,
-                          round_jiffies_relative(HZ));
+       if (ap->pflags & ATA_PFLAG_SCSI_HOTPLUG)
+               queue_delayed_work(ata_aux_wq, &ap->hotplug_task,
+                                  round_jiffies_relative(HZ));
 }
 
 /**
---


Best Regards
Chunbo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/