linux-kernel - Re: [PATCH]: libata-scsi: Don't start hotplug work queue if hotplug is disabled

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <48809BA0.8060500@kernel.org>
Date:	Fri, 18 Jul 2008 22:33:20 +0900
From:	Tejun Heo <tj@...nel.org>
To:	chunbo.luo@...driver.com
CC:	linux-kernel@...r.kernel.org, jeff@...zik.org,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH]: libata-scsi: Don't start hotplug work queue if hotplug
 is	disabled

Chunbo Luo wrote:
> Hi
> 
> When ata_scsi_scan_host() scan device failed, it will start a work queue
> unconditionally. This may cause some noisy messages. This patch fix this
> problem.

ATA_PFLAG_SCSI_HOTPLUG doesn't mean that hotplug is enabled.  It
indicates that EH needs to schedule a kick at SCSI's ass and make it
scan for discovered devices && work running on ata_aux_wq testing it
doesn't mean anything.  There's no synchronization.

>     Previously, queue_delayed_work() was started unconditionally, but if
>     ATA_PFLAG_SCSI_HOTPLUG is not set and we do this, the work queue may
>     cause multiple messages like this:
>     
>     ata3.00: WARNING: ATAPI is not supported with this driver, device ignored.

And this message has nothing to do with SCSI.  It's printed by libata
proper for several drivers which don't support ATAPI.  Did the patch
really kill the warning messages?  Can you please post full boot log
from 2.6.26 w/o the patch?

Andrew, please drop the patch from -mm.  Thanks.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/