linux-kernel - Re: [-mm][PATCH 8/10] fix shmem page migration incorrectness on memcgroup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <28c262360806262208i6791d67at446f7323ded16206@mail.gmail.com>
Date:	Fri, 27 Jun 2008 14:08:08 +0900
From:	"MinChan Kim" <minchan.kim@...il.com>
To:	"KAMEZAWA Hiroyuki" <kamezawa.hiroyu@...fujitsu.com>
Cc:	LKML <linux-kernel@...r.kernel.org>, linux-mm <linux-mm@...ck.org>,
	"Andrew Morton" <akpm@...ux-foundation.org>,
	"Lee Schermerhorn" <Lee.Schermerhorn@...com>,
	"Rik van Riel" <riel@...hat.com>,
	"KOSAKI Motohiro" <kosaki.motohiro@...fujitsu.com>,
	"Daisuke Nishimura" <nishimura@....nes.nec.co.jp>
Subject: Re: [-mm][PATCH 8/10] fix shmem page migration incorrectness on memcgroup

Hi, KAMEZAWA-san.

I have one question.
It's just curious.

On Wed, Jun 25, 2008 at 7:09 PM, KOSAKI Motohiro
<kosaki.motohiro@...fujitsu.com> wrote:
>
> =
> From: KAMEZAWA Hiroyuki <kamezawa.hiroyu@...fujitsu.com>
>
> mem_cgroup_uncharge() against old page is done after radix-tree-replacement.
> And there were special handling to ingore swap-cache page. But, shmem can
> be swap-cache and file-cache at the same time. Chekcing PageSwapCache() is
> not correct here. Check PageAnon() instead.

When/How shmem can be both swap-cache and file-cache ?
I can't understand that situation.

Thanks. :)

> Signed-off-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@...fujitsu.com>
> Acked-by: Daisuke Nishimura <nishimura@....nes.nec.co.jp>
> Signed-off-by: KOSAKI Motohiro <kosaki.motohiro@...fujitsu.com>
>
> ---
>  mm/migrate.c |   11 +++++++++--
>  1 file changed, 9 insertions(+), 2 deletions(-)
>
> Index: b/mm/migrate.c
> ===================================================================
> --- a/mm/migrate.c
> +++ b/mm/migrate.c
> @@ -332,7 +332,13 @@ static int migrate_page_move_mapping(str
>        __inc_zone_page_state(newpage, NR_FILE_PAGES);
>
>        spin_unlock_irq(&mapping->tree_lock);
> -       if (!PageSwapCache(newpage))
> +
> +       /*
> +        * The page is removed from radix-tree implicitly.
> +        * We uncharge it here but swap cache of anonymous page should be
> +        * uncharged by mem_cgroup_ucharge_page().
> +        */
> +       if (!PageAnon(newpage))
>                mem_cgroup_uncharge_cache_page(page);
>
>        return 0;
> @@ -381,7 +387,8 @@ static void migrate_page_copy(struct pag
>                /*
>                 * SwapCache is removed implicitly. Uncharge against swapcache
>                 * should be called after ClearPageSwapCache() because
> -                * mem_cgroup_uncharge_page checks the flag.
> +                * mem_cgroup_uncharge_page checks the flag. shmem's swap cache
> +                * is uncharged before here.
>                 */
>                mem_cgroup_uncharge_page(page);
>        }
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
>



-- 
Kinds regards,
MinChan Kim
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/