linux-kernel - Re: [-mm][PATCH 8/10] fix shmem page migration incorrectness on memcgroup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20080627142950.7A83.KOSAKI.MOTOHIRO@jp.fujitsu.com>
Date:	Fri, 27 Jun 2008 14:41:00 +0900
From:	KOSAKI Motohiro <kosaki.motohiro@...fujitsu.com>
To:	"MinChan Kim" <minchan.kim@...il.com>
Cc:	kosaki.motohiro@...fujitsu.com,
	"KAMEZAWA Hiroyuki" <kamezawa.hiroyu@...fujitsu.com>,
	LKML <linux-kernel@...r.kernel.org>,
	linux-mm <linux-mm@...ck.org>,
	"Andrew Morton" <akpm@...ux-foundation.org>,
	"Lee Schermerhorn" <Lee.Schermerhorn@...com>,
	"Rik van Riel" <riel@...hat.com>,
	"Daisuke Nishimura" <nishimura@....nes.nec.co.jp>
Subject: Re: [-mm][PATCH 8/10] fix shmem page migration incorrectness on memcgroup

> > mem_cgroup_uncharge() against old page is done after radix-tree-replacement.
> > And there were special handling to ingore swap-cache page. But, shmem can
> > be swap-cache and file-cache at the same time. Chekcing PageSwapCache() is
> > not correct here. Check PageAnon() instead.
> 
> When/How shmem can be both swap-cache and file-cache ?
> I can't understand that situation.

Hi

see, 

shmem_writepage()
   -> add_to_swap_cache()
      -> SetPageSwapCache()


BTW: his file-cache mean !Anon, not mean !SwapBacked.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/