linux-kernel - Re: [PATCH 5/5] MMC: cleanup endianity conversions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1214877064.11537.94.camel@violet.holtmann.net>
Date:	Tue, 01 Jul 2008 03:51:04 +0200
From:	Marcel Holtmann <marcel@...tmann.org>
To:	Tomas Winkler <tomas.winkler@...el.com>
Cc:	drzeus-list@...eus.cx, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 5/5] MMC: cleanup endianity conversions

Hi Tomas,

> static int mmc_blk_issue_rq(struct mmc_queue *mq, struct request *req)
> diff --git a/drivers/mmc/core/mmc_ops.c b/drivers/mmc/core/mmc_ops.c
> index e6703e5..3ad340c 100644
> --- a/drivers/mmc/core/mmc_ops.c
> +++ b/drivers/mmc/core/mmc_ops.c
> @@ -271,17 +271,17 @@ mmc_send_cxd_data(struct mmc_card *card, struct mmc_host *host,
>  int mmc_send_csd(struct mmc_card *card, u32 *csd)
>  {
>  	int ret, i;
> -
> +	__be32 csd_buf[4];
>  	if (!mmc_host_is_spi(card->host))
>  		return mmc_send_cxd_native(card->host, card->rca << 16,
>  				csd, MMC_SEND_CSD);

what is up with this empty line removal. I would keep the empty line
after the variable declaration.

>  	for (i = 0;i < 4;i++)
> -		csd[i] = be32_to_cpu(csd[i]);
> +		csd[i] = be32_to_cpu(csd_buf[i]);

While you are at it. Add the missing whitespace in the for statement :)

Otherwise, looks good to me.

Regards

Marcel


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/