linux-kernel - Re: [PATCH 3/5] MMC: fix sdio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1214877295.11537.97.camel@violet.holtmann.net>
Date:	Tue, 01 Jul 2008 03:54:55 +0200
From:	Marcel Holtmann <marcel@...tmann.org>
To:	Tomas Winkler <tomas.winkler@...el.com>
Cc:	drzeus-list@...eus.cx, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/5] MMC: fix sdio_io sparse errors

Hi Tomas,

>  	if (blksz == 0) {
> -		blksz = min(min(
> -			func->max_blksize,
> -			func->card->host->max_blk_size),
> -			512u);
> +		blksz = min(func->max_blksize, func->card->host->max_blk_size);
> +		blksz = min(blksz, 512u);
>  	}

I agree that your version is more readable, but I would be still
interested in which sparse error this fixes.

Other than that the patch looks good.

Regards

Marcel


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/