linux-kernel - Re: [PATCH -next] bug.h: add empty warn_on_slowpath() for CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <23433248.1214943818230.JavaMail.oracle@acsmt302.oracle.com>
Date:	Tue, 1 Jul 2008 15:23:38 -0500 (CDT)
From:	Randy Dunlap <randy.dunlap@...cle.com>
To:	Andrew Morton <akpm@...ux-foundation.org>
Cc:	linux-kernel@...r.kernel.org, andi@...stfloor.org
Subject: Re: [PATCH -next] bug.h: add empty warn_on_slowpath() for CONFIG_BUG=n

--- Original Message ---
> On Tue, 1 Jul 2008 10:33:39 -0700
> Randy Dunlap <randy.dunlap@...cle.com> wrote:
> 
> > From: Randy Dunlap <randy.dunlap@...cle.com>
> > 
> > Add an empty function for warn_on_slowpath() when CONFIG_BUG=n so that
> > this build error does not happen:
> > 
> > linux-next-20080701/drivers/acpi/utilities/utmisc.c: In function 'acpi_ut_error':
> > linux-next-20080701/drivers/acpi/utilities/utmisc.c:1028: error: implicit declaration of function 'warn_on_slowpath'
> > 
> > Signed-off-by: Randy Dunlap <randy.dunlap@...cle.com>
> > ---
> >  include/asm-generic/bug.h |    5 +++++
> >  1 file changed, 5 insertions(+)
> > 
> > --- linux-next-20080701.orig/include/asm-generic/bug.h
> > +++ linux-next-20080701/include/asm-generic/bug.h
> > @@ -81,4 +81,9 @@ extern void warn_on_slowpath(const char 
> >  # define WARN_ON_SMP(x)			do { } while (0)
> >  #endif
> >  
> > +#ifndef __ASSEMBLY__
> > +static inline void warn_on_slowpath(const char *file, const int line)
> > +{ }
> > +#endif
> > +
> >  #endif
> > 
> 
> This looks like a needed-in-mainline fix?  or is there something
> in linux-next which causes the bug?

Looks like only linux-next has this code:

> > linux-next-20080701/drivers/acpi/utilities/utmisc.c: In function 'acpi_ut_error':
> > linux-next-20080701/drivers/acpi/utilities/utmisc.c:1028: error: implicit declaration of function 'warn_on_slowpath'


~Randy

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/