linux-kernel - Re: [linux-pm] [PATCH 1/2] introduce new interface schedule_work

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.44L0.0807031001580.2410-100000@iolanthe.rowland.org>
Date:	Thu, 3 Jul 2008 10:04:18 -0400 (EDT)
From:	Alan Stern <stern@...land.harvard.edu>
To:	Zhang Rui <rui.zhang@...el.com>
cc:	linux-pm <linux-pm@...ts.linux-foundation.org>,
	linux-kernel <linux-kernel@...r.kernel.org>,
	<harbour@...nx.od.ua>
Subject: Re: [linux-pm] [PATCH 1/2] introduce new interface schedule_work_on

On Thu, 3 Jul 2008, Zhang Rui wrote:

> This interface allows adding a job on a specific cpu.
> 
> Although a work struct on a cpu will be scheduled to other cpu if the cpu dies,
> there is a recursion if a work task tries to offline the cpu it's running on.
> we need to schedule the task to a specific cpu in this case.
> http://bugzilla.kernel.org/show_bug.cgi?id=10897
> 
> Signed-off-by: Zhang Rui <rui.zhang@...el.com>
> Tested-by: Rus <harbour@...nx.od.ua>
> ---
>  include/linux/workqueue.h |    1 +
>  kernel/workqueue.c        |   38 ++++++++++++++++++++++++++++++++++++++
>  2 files changed, 39 insertions(+)
> 
> Index: linux-2.6/include/linux/workqueue.h
> ===================================================================
> --- linux-2.6.orig/include/linux/workqueue.h	2008-07-03 11:13:23.000000000 +0800
> +++ linux-2.6/include/linux/workqueue.h	2008-07-03 11:13:25.000000000 +0800
> @@ -188,6 +188,7 @@
>  extern void flush_scheduled_work(void);
>  
>  extern int schedule_work(struct work_struct *work);
> +extern int schedule_work_on(int cpu, struct work_struct *work);
>  extern int schedule_delayed_work(struct delayed_work *work, unsigned long delay);
>  extern int schedule_delayed_work_on(int cpu, struct delayed_work *work,
>  					unsigned long delay);

Is there some reason you don't export queue_work_on?  After all, 
queue_delayed_work_on is exported.

Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/