linux-kernel - Re: [Bug 10868] Oops on loading ipaq module since 2.6.26, prevents use of device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200807031608.46457.oliver@neukum.org>
Date:	Thu, 3 Jul 2008 16:08:44 +0200
From:	Oliver Neukum <oliver@...kum.org>
To:	Adrian Bunk <bunk@...nel.org>
Cc:	Adam Williamson <awilliamson@...driva.com>,
	Alan Cox <alan@...rguk.ukuu.org.uk>,
	Arjan van de Ven <arjan@...radead.org>,
	"Rafael J. Wysocki" <rjw@...k.pl>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Alan Cox <alan@...hat.com>, bugme-daemon@...zilla.kernel.org,
	Greg KH <greg@...ah.com>, linux-usb@...r.kernel.org,
	Matthias Geissert <matthias.geissert@....de>
Subject: Re: [Bug 10868] Oops on loading ipaq module since 2.6.26, prevents use of device

Am Donnerstag 03 Juli 2008 10:57:33 schrieb Adrian Bunk:
> On Thu, Jul 03, 2008 at 10:05:57AM +0200, Oliver Neukum wrote:
 
> > As far as I can tell somebody changed the ipaq driver in 2.6.26-rc6. I cannot
> > find the exact patch that did it in Greg's directory. As it causes a regression
> > here's a reversal.
> 
> 
> It was changed by:

Thanks, did you do git magic?

> commit e1879b19b0abdb387e4aeb0b935a486cc75042fb
> Author: Matthias Geissert <matthias.geissert@....de>
> Date:   Thu Mar 6 22:00:33 2008 +0100
> 
>     USB: ipaq: fix devices having more than one endpoint
>     
>     The ipaq module  supports devices with one endpoint only. Some devices,
>     e.g. Yakumo Delta 300, have more than one endpoint.
>     
>     This patch fixes support for devices having up to 2 endpoints which used
>     to work on older kernel versions.
>     
>     Signed-off-by: Matthias Geissert <matthias.geissert@....de>
>     Signed-off-by: Greg Kroah-Hartman <gregkh@...e.de>
> 
> diff --git a/drivers/usb/serial/ipaq.c b/drivers/usb/serial/ipaq.c
> index 9b38a08..17f2a53 100644
> --- a/drivers/usb/serial/ipaq.c
> +++ b/drivers/usb/serial/ipaq.c
> @@ -571,9 +571,9 @@ static struct usb_serial_driver ipaq_device = {
>  	.usb_driver = 		&ipaq_driver,
>  	.id_table =		ipaq_id_table,
>  	.num_interrupt_in =	NUM_DONT_CARE,
> -	.num_bulk_in =		1,
> -	.num_bulk_out =		1,
> -	.num_ports =		1,
> +	.num_bulk_in =		NUM_DONT_CARE,
> +	.num_bulk_out =		NUM_DONT_CARE,

This is good.

> +	.num_ports =		2,

This is fatal.

The patch I sent reverts only this part, so this issue is solved.

	Regards
		Oliver
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/