linux-kernel - Re: [PATCH -mm] documentation: update CodingStyle tips for Emacs users

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080704134159.4dd9f74e@bike.lwn.net>
Date:	Fri, 4 Jul 2008 13:41:59 -0600
From:	Jonathan Corbet <corbet@....net>
To:	Johannes Weiner <hannes@...urebad.de>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH -mm] documentation: update CodingStyle tips for Emacs
 users

On Fri, 04 Jul 2008 19:52:16 +0200
Johannes Weiner <hannes@...urebad.de> wrote:

> +(add-hook 'c-mode-hook
> +          (lambda ()
> +            (let ((filename (buffer-file-name)))
> +              ;; Enable kernel mode for the appropriate files
> +              (when (and file
> +                         (string-match "/usr/src/linux" filename))

Shouldn't that be "(and filename ..." rather than "file"?

A test for /usr/src/linux seems misplaced, though; I don't think a
whole lot of people keep their kernel trees there anymore.  There must
be a better heuristic one can use to figure out whether a kernel source
file is being edited.

jon
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/