linux-kernel - Re: *sigh* /proc/*/pagemap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LFD.1.10.0807051036000.2815@woody.linux-foundation.org>
Date:	Sat, 5 Jul 2008 10:40:26 -0700 (PDT)
From:	Linus Torvalds <torvalds@...ux-foundation.org>
To:	Andrew Morton <akpm@...ux-foundation.org>
cc:	Alexey Dobriyan <adobriyan@...il.com>,
	torvalds@...uxfoundation.org, akpm@...uxfoundation.org,
	mpm@...enic.com, linux-kernel@...r.kernel.org
Subject: Re: *sigh* /proc/*/pagemap

On Fri, 4 Jul 2008, Andrew Morton wrote:
>  	int pagecount;
>  	int ret = -ESRCH;
> +	static struct mm_walk pagemap_walk;
>  
...
>  
> +	pagemap_walk.pmd_entry = pagemap_pte_range;
> +	pagemap_walk.pte_hole = pagemap_pte_hole;
> +	pagemap_walk.mm = mm;
> +	pagemap_walk.private = &pm;
> +

No can do. You have one single pagemap_walk, but perhaps multiple users, 
who all disagree about what it should contain.

Quite frankly, I think we should just remove the whole f*cking crap. I 
think it's also potentially a security hole to give physical page 
information and swap info - even if it's just your own pages.

Matt, can you explain what the point was of this whole thing? I'm really 
_this_ close to just removing the POS right now. It's been a big source of 
bugs, and it looks entirely pointless.

		Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/