linux-kernel - Re: [PATCH] [0/9] Use 64bit x86 machine check code for 32bit too

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 07 Jul 2008 14:26:38 -0700
From:	"H. Peter Anvin" <hpa@...nel.org>
To:	Andi Kleen <andi@...stfloor.org>
CC:	masbock@...ux.vnet.ibm.com, x86@...nel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] [0/9] Use 64bit x86 machine check code for 32bit too

Andi Kleen wrote:
> This patchkit uses the 64bit machine check code which is better in many
> ways on 32bit x86 too. This is also the basis for some future machine
> check work.

Hi Andi,

I tried applying your patch kit to -tip, but I'm getting build failures 
on i386; gcc-4.1.1-51.fc5.x86_64 with attached configuration.

   CC      crypto/async_tx/async_memcpy.o
/var/tmp/hpa/kbuild/kernel/arch/x86/kernel/cpu/mcheck/mce_64.c: In 
function ‘set_bank0ctl’:
/var/tmp/hpa/kbuild/kernel/arch/x86/kernel/cpu/mcheck/mce_64.c:795: 
warning: passing argument 2 of ‘strict_strtoull’ makes integer from 
pointer without a cast
/var/tmp/hpa/kbuild/kernel/arch/x86/kernel/cpu/mcheck/mce_64.c: In 
function ‘set_bank1ctl’:
/var/tmp/hpa/kbuild/kernel/arch/x86/kernel/cpu/mcheck/mce_64.c:796: 
warning: passing argument 2 of ‘strict_strtoull’ makes integer from 
pointer without a cast
/var/tmp/hpa/kbuild/kernel/arch/x86/kernel/cpu/mcheck/mce_64.c: In 
function ‘set_bank2ctl’:
/var/tmp/hpa/kbuild/kernel/arch/x86/kernel/cpu/mcheck/mce_64.c:797: 
warning: passing argument 2 of ‘strict_strtoull’ makes integer from 
pointer without a cast
/var/tmp/hpa/kbuild/kernel/arch/x86/kernel/cpu/mcheck/mce_64.c: In 
function ‘set_bank3ctl’:
/var/tmp/hpa/kbuild/kernel/arch/x86/kernel/cpu/mcheck/mce_64.c:798: 
warning: passing argument 2 of ‘strict_strtoull’ makes integer from 
pointer without a cast
/var/tmp/hpa/kbuild/kernel/arch/x86/kernel/cpu/mcheck/mce_64.c: In 
function ‘set_bank4ctl’:
/var/tmp/hpa/kbuild/kernel/arch/x86/kernel/cpu/mcheck/mce_64.c:799: 
warning: passing argument 2 of ‘strict_strtoull’ makes integer from 
pointer without a cast
/var/tmp/hpa/kbuild/kernel/arch/x86/kernel/cpu/mcheck/mce_64.c: In 
function ‘set_bank5ctl’:
/var/tmp/hpa/kbuild/kernel/arch/x86/kernel/cpu/mcheck/mce_64.c:800: 
warning: passing argument 2 of ‘strict_strtoull’ makes integer from 
pointer without a cast
/var/tmp/hpa/kbuild/kernel/arch/x86/kernel/cpu/mcheck/mce_64.c: In 
function ‘set_tolerant’:
/var/tmp/hpa/kbuild/kernel/arch/x86/kernel/cpu/mcheck/mce_64.c:822: 
warning: passing argument 2 of ‘strict_strtoull’ makes integer from 
pointer without a cast
/var/tmp/hpa/kbuild/kernel/arch/x86/kernel/cpu/mcheck/mce_64.c: In 
function ‘set_check_interval’:
/var/tmp/hpa/kbuild/kernel/arch/x86/kernel/cpu/mcheck/mce_64.c:823: 
warning: passing argument 2 of ‘strict_strtoull’ makes integer from 
pointer without a cast
   CC      kernel/sched_clock.o
   CC      security/selinux/ss/hashtab.o
   CC      fs/xattr.o
   CC      mm/swapfile.o
   CC      security/selinux/ss/symtab.o
   CC      crypto/async_tx/async_xor.o
   CC      arch/x86/kernel/cpu/mcheck/mce_intel_64.o
   CC      kernel/sysctl_check.o
   CC      security/selinux/ss/sidtab.o
/var/tmp/hpa/kbuild/kernel/arch/x86/kernel/cpu/mcheck/mce_intel_64.c: In 
function ‘smp_thermal_interrupt’:
/var/tmp/hpa/kbuild/kernel/arch/x86/kernel/cpu/mcheck/mce_intel_64.c:20: 
error: implicit declaration of function ‘ack_APIC_irq’
/var/tmp/hpa/kbuild/kernel/arch/x86/kernel/cpu/mcheck/mce_intel_64.c:29: 
error: implicit declaration of function ‘add_pda’
/var/tmp/hpa/kbuild/kernel/arch/x86/kernel/cpu/mcheck/mce_intel_64.c:29: 
error: ‘irq_thermal_count’ undeclared (first use in this function)
/var/tmp/hpa/kbuild/kernel/arch/x86/kernel/cpu/mcheck/mce_intel_64.c:29: 
error: (Each undeclared identifier is reported only once
/var/tmp/hpa/kbuild/kernel/arch/x86/kernel/cpu/mcheck/mce_intel_64.c:29: 
error: for each function it appears in.)
/var/tmp/hpa/kbuild/kernel/arch/x86/kernel/cpu/mcheck/mce_intel_64.c: In 
function ‘intel_init_thermal’:
/var/tmp/hpa/kbuild/kernel/arch/x86/kernel/cpu/mcheck/mce_intel_64.c:50: 
error: implicit declaration of function ‘apic_read’
/var/tmp/hpa/kbuild/kernel/arch/x86/kernel/cpu/mcheck/mce_intel_64.c:50: 
error: ‘APIC_LVTTHMR’ undeclared (first use in this function)
/var/tmp/hpa/kbuild/kernel/arch/x86/kernel/cpu/mcheck/mce_intel_64.c:51: 
error: ‘APIC_DM_SMI’ undeclared (first use in this function)
/var/tmp/hpa/kbuild/kernel/arch/x86/kernel/cpu/mcheck/mce_intel_64.c:60: 
error: ‘APIC_VECTOR_MASK’ undeclared (first use in this function)
/var/tmp/hpa/kbuild/kernel/arch/x86/kernel/cpu/mcheck/mce_intel_64.c:68: 
error: ‘APIC_DM_FIXED’ undeclared (first use in this function)
/var/tmp/hpa/kbuild/kernel/arch/x86/kernel/cpu/mcheck/mce_intel_64.c:68: 
error: ‘APIC_LVT_MASKED’ undeclared (first use in this function)
/var/tmp/hpa/kbuild/kernel/arch/x86/kernel/cpu/mcheck/mce_intel_64.c:69: 
error: implicit declaration of function ‘apic_write’
make[4]: *** [arch/x86/kernel/cpu/mcheck/mce_intel_64.o] Error 1

View attachment "config.i386" of type "text/plain" (61246 bytes)